linux-kernel - Re: [GIT PULL 12/22] intel_th: msu: Support multipage blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190503161519.GA8488@kroah.com>
Date:   Fri, 3 May 2019 18:15:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL 12/22] intel_th: msu: Support multipage blocks

On Fri, May 03, 2019 at 11:44:45AM +0300, Alexander Shishkin wrote:
> @@ -1481,7 +1501,7 @@ nr_pages_show(struct device *dev, struct device_attribute *attr, char *buf)
>  	else if (msc->mode == MSC_MODE_MULTI) {
>  		list_for_each_entry(win, &msc->win_list, entry) {
>  			count += scnprintf(buf + count, PAGE_SIZE - count,
> -					   "%d%c", win->nr_blocks,
> +					   "%d%c", win->nr_pages,
>  					   msc_is_last_win(win) ? '\n' : ',');
>  		}
>  	} else {

Why do you have a sysfs file that has multiple values?  I will not take
a patch that adds to this mess, please remove this file and fix it up
properly.

thanks,

greg k-h