linux-kernel - Re: [PATCH] edac: sifive: Add EDAC platform driver for SiFive SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1905031206450.4777@viisi.sifive.com>
Date:   Fri, 3 May 2019 12:25:52 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     James Morse <james.morse@....com>
cc:     Yash Shah <yash.shah@...ive.com>, linux-edac@...r.kernel.org,
        linux-riscv@...ts.infradead.org, palmer@...ive.com, bp@...en8.de,
        paul.walmsley@...ive.com, linux-kernel@...r.kernel.org,
        aou@...s.berkeley.edu, mchehab@...nel.org, sachin.ghadi@...ive.com,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        nicolas.ferre@...rochip.com, paulmck@...ux.ibm.com
Subject: Re: [PATCH] edac: sifive: Add EDAC platform driver for SiFive SoCs

Hi James,

On Thu, 2 May 2019, James Morse wrote:

> Having an separately posted dependency like this is tricky, as this code can't be
> used/tested until the other bits are merged.

...

> Looks good to me. I think this patch should go with its two dependencies, I'm not sure why
> it got split off...

The split was due to my suggestion to Yash, I think.  The motivation was 
to decouple the L2 cache controller driver's journey upstream from the 
EDAC driver's upstream path.  The patches will go up via separate trees, 
so the idea was to avoid blocking the L2 cache controller driver on the 
EDAC driver review path.

Thanks for your review,


- Paul