linux-kernel - Re: [PATCH 1/8] sysfs: Add sysfs_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190504135344.GB6989@kroah.com>
Date:   Sat, 4 May 2019 15:53:44 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/8] sysfs: Add sysfs_update_groups function

On Sat, May 04, 2019 at 02:52:00PM +0200, Jiri Olsa wrote:
> Adding sysfs_update_groups function to update
> multiple groups.
> 
> TODO:
> 
> I'm not sure how to handle error path in here,
> currently it removes the whole updated group
> together with already existing (not updated)
> attributes.

I think that should be fine.  The chance of an error happening here is
really slim.

> Signed-off-by: Jiri Olsa <jolsa@...nel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>