[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 6 May 2019 01:02:35 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
Florian Westphal <fw@...len.de>,
"David S. Miller" <davem@...emloft.net>,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] netfilter: xt_hashlimit: use struct_size() helper
On Wed, May 01, 2019 at 05:01:08PM -0500, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, replace code of the following form:
>
> sizeof(struct xt_hashlimit_htable) + sizeof(struct hlist_head) * size
>
> with:
>
> struct_size(hinfo, hash, size)
>
> This code was detected with the help of Coccinelle.
Applied, thanks.
Powered by blists - more mailing lists