linux-kernel - Re: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190506194936.GA23707@gmail.com>
Date:   Mon, 6 May 2019 21:49:36 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Len Brown <lenb@...nel.org>
Cc:     X86 ML <x86@...nel.org>, linux-kernel@...r.kernel.org,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Len Brown <len.brown@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package


* Len Brown <lenb@...nel.org> wrote:

> On Mon, May 6, 2019 at 7:48 AM Ingo Molnar <mingo@...nel.org> wrote:
> 
> > > -     unsigned int pkgid = topology_logical_package_id(cpu);
> > > +     unsigned int pkgid = topology_logical_die_id(cpu);
> 
> > There's many such instances left in this series, please review the whole
> > patchset for such problems.
> 
> I agree, the legacy names make the code read as if it were a bug, even
> when it is correct.
> I'll refresh the series with some re-names to make the end result ready clearly.

Thanks a lot!

	Ingo