lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 May 2019 14:11:20 -0700 From: Tony Lindgren <tony@...mide.com> To: Daniel Lezcano <daniel.lezcano@...aro.org> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>, linux-kbuild@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>, Alexey Gladkov <gladkov.alexey@...il.com>, linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, Lee Jones <lee.jones@...aro.org>, Aaro Koskinen <aaro.koskinen@....fi>, linux-omap@...r.kernel.org, Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro * Daniel Lezcano <daniel.lezcano@...aro.org> [190506 17:40]: > On 06/05/2019 19:28, Masahiro Yamada wrote: > > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > > successfully compiled because they are never built as a module by > > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > > > A problem showed up when a patch "moduleparam: Save information about > > built-in modules in separate file" is applied. With this new feature, > > MODULE_*() are populated even if the callers are built-in. > > > > To avoid the build errors, the lines referencing to the undefined > > macro must be removed. > > > > The complete fix is to remove all MODULE_* and #include <linux/module.h> > > like many "make ... explicitly non-modular" commits did. > > > > For now, I am touching the offending lines. > > > > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > > --- > > Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org> Thanks, please feel free to merge together with your series: Acked-by: Tony Lindgren <tony@...mide.com> Or if you want me to queue it separately, please let me know. Regards, Tony
Powered by blists - more mailing lists