linux-kernel - RE: [PATCH net-next v2 4/4] net: usb: smsc: fix warning reported by kbuild test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 May 2019 21:29:18 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <ynezz@...e.cz>, <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <steve.glendinning@...well.net>, <UNGLinuxDriver@...rochip.com>
CC:     <andrew@...n.ch>, <f.fainelli@...il.com>, <hkallweit1@...il.com>,
        <frowand.list@...il.com>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <maxime.ripard@...tlin.com>, <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net-next v2 4/4] net: usb: smsc: fix warning reported by
 kbuild test robot

> This patch fixes following warning reported by kbuild test robot:
> 
>  In function ‘memcpy’,
>      inlined from ‘smsc75xx_init_mac_address’ at drivers/net/usb/smsc75xx.c:778:3,
>      inlined from ‘smsc75xx_bind’ at drivers/net/usb/smsc75xx.c:1501:2:
>  ./include/linux/string.h:355:9: warning: argument 2 null where non-null expected [-Wnonnull]
>    return __builtin_memcpy(p, q, size);
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  drivers/net/usb/smsc75xx.c: In function ‘smsc75xx_bind’:
>  ./include/linux/string.h:355:9: note: in a call to built-in function ‘__builtin_memcpy’
> 
> I've replaced the offending memcpy with ether_addr_copy, because I'm
> 100% sure, that of_get_mac_address can't return NULL as it returns valid
> pointer or ERR_PTR encoded value, nothing else.
> 
> I'm hesitant to just change IS_ERR into IS_ERR_OR_NULL check, as this
> would make the warning disappear also, but it would be confusing to
> check for impossible return value just to make a compiler happy.
> 
> Fixes: adfb3cb2c52e ("net: usb: support of_get_mac_address new ERR_PTR error")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Petr Štetiar <ynezz@...e.cz>
> ---

Reviewed-by: Woojung Huh <woojung.huh@...rochip.com>