linux-kernel - Re: [PATCH] platform/x86: sony-laptop: Fix unintentional fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82651475-7e46-4590-2ada-2c7e8384a992@embeddedor.com>
Date:   Mon, 6 May 2019 16:35:21 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mattia Dongili <malattia@...ux.it>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] platform/x86: sony-laptop: Fix unintentional fall-through



On 5/6/19 7:23 AM, Andy Shevchenko wrote:
> On Wed, May 1, 2019 at 11:42 PM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
> 
> Pushed to my review and testing queue, thanks!
> 

Awesome. :)

Thanks, Andy.
--
Gustavo

> 
>>
>> Thanks
>> --
>> Gustavo
>>
>> On 4/24/19 1:09 PM, Gustavo A. R. Silva wrote:
>>> It seems that the default case should return AE_CTRL_TERMINATE, instead
>>> of falling through to case ACPI_RESOURCE_TYPE_END_TAG and returning AE_OK;
>>> otherwise the line of code at the end of the function is unreachable and
>>> makes no sense:
>>>
>>> return AE_CTRL_TERMINATE;
>>>
>>> This fix is based on the following thread of discussion:
>>>
>>> https://lore.kernel.org/patchwork/patch/959782/
>>>
>>> Fixes: 33a04454527e ("sony-laptop: Add SNY6001 device handling (sonypi reimplementation)")
>>> Cc: stable@...r.kernel.org
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>>> ---
>>>  drivers/platform/x86/sony-laptop.c | 8 +++++---
>>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
>>> index 4bfbfa3f78e6..2058445fc456 100644
>>> --- a/drivers/platform/x86/sony-laptop.c
>>> +++ b/drivers/platform/x86/sony-laptop.c
>>> @@ -4424,14 +4424,16 @@ sony_pic_read_possible_resource(struct acpi_resource *resource, void *context)
>>>                       }
>>>                       return AE_OK;
>>>               }
>>> +
>>> +     case ACPI_RESOURCE_TYPE_END_TAG:
>>> +             return AE_OK;
>>> +
>>>       default:
>>>               dprintk("Resource %d isn't an IRQ nor an IO port\n",
>>>                       resource->type);
>>> +             return AE_CTRL_TERMINATE;
>>>
>>> -     case ACPI_RESOURCE_TYPE_END_TAG:
>>> -             return AE_OK;
>>>       }
>>> -     return AE_CTRL_TERMINATE;
>>>  }
>>>
>>>  static int sony_pic_possible_resources(struct acpi_device *device)
>>>
> 
> 
>