linux-kernel - [PATCH 2/2] usbip: Remove repeated setting of hcd->state in vhci_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190506125550.7826-2-suwan.kim027@gmail.com>
Date:   Mon,  6 May 2019 21:55:50 +0900
From:   Suwan Kim <suwan.kim027@...il.com>
To:     shuah@...nel.org, valentina.manea.m@...il.com,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Suwan Kim <suwan.kim027@...il.com>
Subject: [PATCH 2/2] usbip: Remove repeated setting of hcd->state in vhci_bus_resume()

When hcd resumes, hcd_bus_resume() calls vhci_bus_resume() which sets
hcd->state as HC_STATE_RUNNING. But after calling vhci_bus_resume(),
hcd_bus_resume() also sets hcd->state as HC_STATE_RUNNING. So, setting
hcd->state in vhci_hcd_resume() is unnecessary.

Signed-off-by: Suwan Kim <suwan.kim027@...il.com>
---
 drivers/usb/usbip/vhci_hcd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index e6f378d00fb6..335d61676fb4 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1252,8 +1252,6 @@ static int vhci_bus_resume(struct usb_hcd *hcd)
 	spin_lock_irqsave(&vhci->lock, flags);
 	if (!HCD_HW_ACCESSIBLE(hcd))
 		rc = -ESHUTDOWN;
-	else
-		hcd->state = HC_STATE_RUNNING;
 	spin_unlock_irqrestore(&vhci->lock, flags);
 
 	return rc;
-- 
2.20.1