linux-kernel - Re: [PATCH -next] ocxl: Fix return value check in afu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <44yPNY0bjTz9s7T@ozlabs.org>
Date:   Mon,  6 May 2019 23:54:05 +1000 (AEST)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alastair D'Silva <alastair@...ilva.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, kernel-janitors@...r.kernel.org,
        Wei Yongjun <weiyongjun1@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ocxl: Fix return value check in afu_ioctl()

On Sat, 2019-05-04 at 07:04:30 UTC, Wei Yongjun wrote:
> In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
> 
> This issue was detected by using the Coccinelle software.
> 
> Fixes: 060146614643 ("ocxl: move event_fd handling to frontend")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> Acked-by: Alastair D'Silva <alastair@...ilva.org>
> Acked-by: Andrew Donnellan <ajd@...ux.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6be6a8de1b55e719e3f9589491074371

cheers