linux-kernel - Re: [PATCH] drivers: thermal: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7e0708b951b5848a1a8cd3be1e9cf1ffa112cb4.camel@linux.intel.com>
Date:   Mon, 06 May 2019 08:09:18 -0700
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Zhang Rui <rui.zhang@...el.com>, edubezval@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: thermal: processor_thermal: Downgrade error
 message

On Mon, 2019-05-06 at 20:50 +0800, Zhang Rui wrote:
> On 一, 2019-04-29 at 20:42 -0700, Srinivas Pandruvada wrote:
> > Downgrade "Unsupported event" message from dev_err to dev_dbg.
> > Otherwise it
> > floods with this message one some platforms.
> > 
> > Signed-off-by: Srinivas Pandruvada <
> > srinivas.pandruvada@...ux.intel.c
> > om>
> > ---
> >  .../thermal/intel/int340x_thermal/processor_thermal_device.c    |
> > 2
> > +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > index 4b206b594825..436c256f111d 100644
> > ---
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > +++
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> > @@ -275,7 +275,7 @@ static void proc_thermal_notify(acpi_handle
> > handle, u32 event, void *data)
> >  				THERMAL_DEVICE_POWER_CAPABILITY_CHAN
> > GED);
> >  		break;
> >  	default:
> > -		dev_err(proc_priv->dev, "Unsupported event
> > [0x%x]\n", event);
> > +		dev_dbg(proc_priv->dev, "Unsupported event
> > [0x%x]\n", event);
> >  		break;
> >  	}
> >  }
> 
> a similar patch has been applied, the only difference is that I'm
> using
> dev_notice instead.
> 
https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git/commit
> /?h=next&id=3c7110fab805766450c5d2eac1c994d4c8c230d3

I think dev_notice still appear with non debug log level (!=7), so
dmesg from most distro will still have this print, which will concern
some users unnecessarily, which we can't do anything.

Thanks,
Srinivas

> 
> thanks,
> rui