linux-kernel - Re: [PATCH] apparmor: Force type-casting of current->real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6acda78-1979-6431-d7a2-26c277b7d6ee@canonical.com>
Date:   Tue, 7 May 2019 12:53:45 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     Bharath Vedartham <linux.bhar@...il.com>, jmorris@...ei.org,
        serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: Force type-casting of current->real_cred

On 4/23/19 9:53 AM, Bharath Vedartham wrote:
> This patch fixes the sparse warning:
> warning: cast removes address space '<asn:4>' of expression.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>


Acked-by: John Johansen <john.johansen@...onical.com>

I will pull this into my tree

> ---
>  security/apparmor/lsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 87500bd..36478c4 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1529,7 +1529,7 @@ static int param_set_mode(const char *val, const struct kernel_param *kp)
>   */
>  static int __init set_init_ctx(void)
>  {
> -	struct cred *cred = (struct cred *)current->real_cred;
> +	struct cred *cred = (__force struct cred *)current->real_cred;
>  
>  	set_cred_label(cred, aa_get_label(ns_unconfined(root_ns)));
>  
> 

Acked-by: John Johansen <john.johansen@...onical.com>