linux-kernel - Re: [PATCH 1/5] clk: ingenic: Add missing header in cgu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 May 2019 13:19:17 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     James Hogan <jhogan@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Paul Burton <paul.burton@...s.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Ralf Baechle <ralf@...ux-mips.org>
Cc:     od@...c.me, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Paul Cercueil <paul@...pouillou.net>
Subject: Re: [PATCH 1/5] clk: ingenic: Add missing header in cgu.h

Quoting Paul Cercueil (2019-05-07 12:34:17)
> The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw'
> structures (no pointers), so the <linux/clk-provider.h> header should be
> included.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/clk/ingenic/cgu.h         | 1 +
>  drivers/clk/ingenic/jz4725b-cgu.c | 1 -
>  drivers/clk/ingenic/jz4740-cgu.c  | 1 -
>  drivers/clk/ingenic/jz4770-cgu.c  | 1 -
>  drivers/clk/ingenic/jz4780-cgu.c  | 1 -
>  5 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/ingenic/cgu.h b/drivers/clk/ingenic/cgu.h
> index e12716d8ce3c..c18198ba2955 100644
> --- a/drivers/clk/ingenic/cgu.h
> +++ b/drivers/clk/ingenic/cgu.h
> @@ -19,6 +19,7 @@
>  #define __DRIVERS_CLK_INGENIC_CGU_H__
>  
>  #include <linux/bitops.h>
> +#include <linux/clk-provider.h>
>  #include <linux/of.h>
>  #include <linux/spinlock.h>
>  
> diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c
> index 584ff4ff81c7..044bbd271bb6 100644
> --- a/drivers/clk/ingenic/jz4725b-cgu.c
> +++ b/drivers/clk/ingenic/jz4725b-cgu.c
> @@ -6,7 +6,6 @@
>   * Author: Paul Cercueil <paul@...pouillou.net>
>   */
>  
> -#include <linux/clk-provider.h>

Please leave these here. We want to keep around explicit includes so we
don't get implicit include problems like we just experienced with io.h
not being included in various clk drivers because clk-provider.h did it
for them.