linux-kernel - Re: [PATCH] usb: gadget: configfs: Add lpm_Ux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1557264537.26527.14.camel@phaseone.com>
Date:   Tue, 7 May 2019 21:28:59 +0000
From:   "Claus H. Stovgaard" <cst@...seone.com>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
CC:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>
Subject: Re: [PATCH] usb: gadget: configfs: Add lpm_Ux_disable

Hi Thinh

On tir, 2019-05-07 at 18:53 +0000, Thinh Nguyen wrote:
> Claus H. Stovgaard wrote:
> > 
> > Where Anurags patch focus on setting U1/U2 latency in the BOS
> > descriptor from the devicetree, this patch focuses on having a
> > configfs
> > interface for forcing the UDC (here the dwc3) to not enable U1/U2
> > and
> > reject the SET_SEL(U1/U2).
> > 
> > Looking forward to input.
> > 
> > [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinic
> > s.net_lists_linux-
> > 2Dusb_msg179732.html&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyh
> > jrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-
> > w&m=wKdyWmYpbW791LAm7rYwvFYx5E0bjENyXZzHvK4vyFo&s=es7kki6iuLJUp2rJn
> > zP9alXKyfJPNSfyxTVCKKDd_rQ&e=
> > [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinic
> > s.net_lists_linux-
> > 2Dusb_msg179393.html&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyh
> > jrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-
> > w&m=wKdyWmYpbW791LAm7rYwvFYx5E0bjENyXZzHvK4vyFo&s=cFTmO9wPf7b6TZxFU
> > AAIJM0Z_wM1ttNIc1rct0uR6co&e=
> > 
> > 
> 
> I'm not sure who will submit the patch to make change to DWC3 for
> disabling U1/U2 (Anurag or you), but can you split your patch between
> dwc3 and configfs.

Have just written with Anurag, and he will submit a new patch set,
where he has taken the control in ep0.c from my patch, and combined
with his devicetree bindings. So the plan is to drop the configfs
interface completely, keep the devicetree binding names (dis-u1-entry-
quirk) and let it do 3 things.
*Sets the latency to 0 in the BOS
*Disable U1/U2 acceptence
*Disable U1/U2 initiating
This also include rejecting SET_SEL.

We think this is the best option, and then dropping this patch as it
is.

I will just send and email later on this thread, when the patch is
available on marc.info as a link for reference to the future.

Thanks
Claus