linux-kernel - Re: [PATCH -next] hid: fix hid-logitech-dj build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO-hwJKueMUp=4ioCNhgkX2+HWsd9GV4bkKi_+uvzpOV_UED8A@mail.gmail.com>
Date:   Tue, 7 May 2019 09:04:53 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Jiri Kosina <jikos@...nel.org>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH -next] hid: fix hid-logitech-dj build error

Hi Randy,

On Tue, May 7, 2019 at 3:12 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build error in hid-logitech-dj by making it depend on
> USB_HID, like several other HID drivers do.
>
> Fixes this build error:
>
> ERROR: "usb_hid_driver" [drivers/hid/hid-logitech-dj.ko] undefined!
>
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: linux-input@...r.kernel.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  drivers/hid/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- mmotm-2019-0425-1630.orig/drivers/hid/Kconfig
> +++ mmotm-2019-0425-1630/drivers/hid/Kconfig
> @@ -522,6 +522,7 @@ config HID_LOGITECH
>  config HID_LOGITECH_DJ
>         tristate "Logitech Unifying receivers full support"
>         depends on HIDRAW
> +       depends on USB_HID

this is already scheduled in the HID PR:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-linus&id=c08f38e9fd0b5486957ed42438ec8fa9b6ebbf4f

Cheers,
Benjamin

>         depends on HID_LOGITECH
>         select HID_LOGITECH_HIDPP
>         ---help---
>
>