linux-kernel - Re: [PATCH 2/2] mmc: sdhci-milbeaut: add Milbeaut SD controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190507181831.9D75.F0D17A80@socionext.com>
Date:   Tue, 7 May 2019 09:18:40 +0000
From:   <orito.takao@...ionext.com>
To:     <ulf.hansson@...aro.org>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <masami.hiramatsu@...aro.org>,
        <jaswinder.singh@...aro.org>, <sugaya.taichi@...ionext.com>,
        <kasai.kazuhiro@...ionext.com>, <kanematsu.shinji@...ionext.com>
Subject: Re: [PATCH 2/2] mmc: sdhci-milbeaut: add Milbeaut SD controller
 driver


Thank you for reviewing my patches.

> [...]
> 
> > +
> > +static void sdhci_milbeaut_power_off(struct sdhci_host *host)
> > +{
> > +       struct f_sdhost_priv *priv = sdhci_priv(host);
> > +
> > +       gpiod_set_value(priv->power_gpio, 0);
> > +       udelay(1000);
> > +}
> > +
> > +static void sdhci_milbeaut_power_on(struct sdhci_host *host)
> > +{
> > +       struct f_sdhost_priv *priv = sdhci_priv(host);
> > +
> > +       gpiod_set_value(priv->power_gpio, 1);
> > +}
> > +
> 
> As stated for the DT doc patch, please use a fixed GPIO regulator
> instead. In this way you will also get a the OCR mask based upon the
> GPIO regulator, which is parsed out by the mmc core when sdhci calls
> mmc_regulator_get_supply().

I see. I will update this part too at the view point of using regurator.

Thanks
Orito

> 
> Otherwise, this looks good to me.
> 
> [...]
> 
> Kind regards
> Uffe

-- 
Takao Orito <orito.takao@...ionext.com>