lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 May 2019 13:57:30 +0100 From: Lee Jones <lee.jones@...aro.org> To: Marek Vasut <marek.vasut@...il.com> Cc: Rob Herring <robh@...nel.org>, Mason Yang <masonccyang@...c.com.tw>, broonie@...nel.org, linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org, bbrezillon@...nel.org, linux-renesas-soc@...r.kernel.org, Geert Uytterhoeven <geert+renesas@...der.be>, sergei.shtylyov@...entembedded.com, mark.rutland@....com, devicetree@...r.kernel.org, juliensu@...c.com.tw, Simon Horman <horms@...ge.net.au>, zhengxunli@...c.com.tw Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings On Wed, 24 Apr 2019, Marek Vasut wrote: > On 4/24/19 11:23 PM, Rob Herring wrote: > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. > >> > >> Signed-off-by: Mason Yang <masonccyang@...c.com.tw> > >> --- > >> .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 40 ++++++++++++++++++++++ > >> 1 file changed, 40 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> new file mode 100644 > >> index 0000000..668b822 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> @@ -0,0 +1,40 @@ > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings > >> +-------------------------------------------------- > > > > Looks like a SPI flash controller from the example. What makes it an > > MFD? > > It supports both SPI NOR and HyperFlash (CFI-compliant flash with > different bus interface). Looks like you're registering one OR the other. Why don't you just do this from DT? No reason for this to be an MFD IMHO. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists