linux-kernel - Re: [PATCH] iommu/amd: print out "tag" in INVALID_PPR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea379dc8-dd6b-f204-0abc-7b6fe87a851b@amd.com>
Date:   Tue, 7 May 2019 13:47:35 +0000
From:   Gary R Hook <ghook@....com>
To:     Qian Cai <cai@....pw>, "jroedel@...e.de" <jroedel@...e.de>
CC:     "Hook, Gary" <Gary.Hook@....com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/amd: print out "tag" in INVALID_PPR_REQUEST

On 5/5/19 11:11 PM, Qian Cai wrote:
> [CAUTION: External Email]
> 
> The commit e7f63ffc1bf1 ("iommu/amd: Update logging information for new
> event type") introduced a variable "tag" but had never used it which
> generates a warning below,
> 
> drivers/iommu/amd_iommu.c: In function 'iommu_print_event':
> drivers/iommu/amd_iommu.c:567:33: warning: variable 'tag' set but not
> used [-Wunused-but-set-variable]
>    int type, devid, pasid, flags, tag;
>                                   ^~~
> so just use it during the logging.
> 
> Signed-off-by: Qian Cai <cai@....pw>
> ---
>   drivers/iommu/amd_iommu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index f7cdd2ab7f11..52f41369c5b3 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -631,9 +631,9 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
>                  pasid = ((event[0] >> 16) & 0xFFFF)
>                          | ((event[1] << 6) & 0xF0000);
>                  tag = event[1] & 0x03FF;
> -               dev_err(dev, "Event logged [INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%llx flags=0x%04x]\n",
> +               dev_err(dev, "Event logged [INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x tag=0x%04x address=0x%llx flags=0x%04x]\n",
>                          PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
> -                       pasid, address, flags);
> +                       pasid, tag, address, flags);
>                  break;
>          default:
>                  dev_err(dev, "Event logged [UNKNOWN event[0]=0x%08x event[1]=0x%08x event[2]=0x%08x event[3]=0x%08x\n",

I did manage to overlook that variable when I posted the original patch. 
But it looks to me like 41e59a41fc5d1 (iommu tree) already fixed this... 
I'm not sure why it never got pushed to the main tree.

grh