linux-kernel - Re: [PATCH 3/3] iio: stmpe-adc: Enable all stmpe-adc interrupts just once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80da5f910849a1ee79e1e75cd43a8650c151a159.camel@toradex.com>
Date:   Tue, 7 May 2019 14:32:34 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "jic23@...nel.org" <jic23@...nel.org>
CC:     "stefan@...er.ch" <stefan@...er.ch>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "knaack.h@....de" <knaack.h@....de>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 3/3] iio: stmpe-adc: Enable all stmpe-adc interrupts just
 once

On Sun, 2019-05-05 at 16:45 +0100, Jonathan Cameron wrote:
> On Fri,  3 May 2019 15:57:25 +0200
> Philippe Schenker <dev@...henker.ch> wrote:
> 
> > From: Philippe Schenker <philippe.schenker@...adex.com>
> > 
> > This commit will enable the interrupts of all channels handled by this
> > driver only once in the probe function.
> > 
> > This will improve performance because one byte less has to be written over
> > i2c on each read out of the adc. On the fastest ADC mode this will improve
> > read out speed by 15%.
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> Makes sense. I'll pick this up once patch 2 discussion is sorted.
> 
> Jonathan

Please ignore this patch here as I send a completely new series that includes
this one.
> 
> > ---
> > 
> >  drivers/iio/adc/stmpe-adc.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> > index baa41ffc0d76..427c890c6e7d 100644
> > --- a/drivers/iio/adc/stmpe-adc.c
> > +++ b/drivers/iio/adc/stmpe-adc.c
> > @@ -72,9 +72,6 @@ static int stmpe_read_voltage(struct stmpe_adc *info,
> >  		return -EINVAL;
> >  	}
> >  
> > -	stmpe_reg_write(info->stmpe, STMPE_REG_ADC_INT_EN,
> > -			STMPE_ADC_CH(info->channel));
> > -
> >  	stmpe_reg_write(info->stmpe, STMPE_REG_ADC_CAPT,
> >  			STMPE_ADC_CH(info->channel));
> >  
> > @@ -328,6 +325,9 @@ static int stmpe_adc_probe(struct platform_device *pdev)
> >  	if (ret)
> >  		return ret;
> >  
> > +	stmpe_reg_write(info->stmpe, STMPE_REG_ADC_INT_EN,
> > +			~(norequest_mask & 0xFF));
> > +
> >  	return devm_iio_device_register(&pdev->dev, indio_dev);
> >  }
> >