linux-kernel - Re: [PATCH v2] checkpatch: add command-line option for TAB size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAj6DX0CQtB8y71bc-X36i4V36R5WjJ2199JiR4+717T1sDNqA@mail.gmail.com>
Date:   Thu, 9 May 2019 00:03:32 +0200
From:   Antonio Borneo <borneo.antonio@...il.com>
To:     "Elliott, Robert (Servers)" <elliott@....com>
Cc:     Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] checkpatch: add command-line option for TAB size

On Wed, May 8, 2019 at 11:14 PM Elliott, Robert (Servers)
<elliott@....com> wrote:
...
> Checking for 0 before using the value in division and modulo
> operations would be prudent.

True!
>From command line, $tabsize is parsed as integer so I should sort out
any non-positive value.
Will add a check after GetOptions(...)
die "Invalid TAB size: $tabsize\n" if ($tabsize <= 0);