linux-kernel - Re: [PATCH v4 0/2] net: phy: realtek: Fix RGMII TX/RX-delays initial config of rtl8211(e|f)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190508.163152.1104213638206267502.davem@davemloft.net>
Date:   Wed, 08 May 2019 16:31:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fancer.lancer@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, hkallweit1@...il.com,
        olteanv@...il.com, martin.blumenstingl@...glemail.com,
        Sergey.Semin@...latforms.ru, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] net: phy: realtek: Fix RGMII TX/RX-delays
 initial config of rtl8211(e|f)

From: Serge Semin <fancer.lancer@...il.com>
Date: Thu,  9 May 2019 00:51:13 +0300

> It has been discovered that RX/TX delays of rtl8211e ethernet PHY
> can be configured via a MDIO register hidden in the extension pages
> layout. Particularly the extension page 0xa4 provides a register 0x1c,
> which bits 1 and 2 control the described delays. They are used to
> implement the "rgmii-{id,rxid,txid}" phy-mode support in patch 1.
> 
> The second patch makes sure the rtl8211f TX-delay is configured only
> if RGMII interface mode is specified including the rgmii-rxid one.
> In other cases (most importantly for NA mode) the delays are supposed
> to be preconfigured by some other software or hardware and should be
> left as is without any modification. The similar thing is also done
> for rtl8211e in the patch 1 of this series.
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> 
> Changelog v3
> - Add this cover-letter.
> - Add Andrew' Reviewed-by tag to patch 1.
> - Accept RGMII_RXID interface mode for rtl8211f and clear the TX_DELAY
>   bit in this case.
> - Initialize ret variable with 0 to prevent the "may be used uninitialized"
>   warning in patch 1.
> 
> Changelog v4
> - Rebase onto net-next

Series applied.