linux-kernel - Re: [GIT PULL] Staging/IIO driver patches for 5.2-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190508094929.GC6996@kroah.com>
Date:   Wed, 8 May 2019 11:49:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        devel@...uxdriverproject.org
Subject: Re: [GIT PULL] Staging/IIO driver patches for 5.2-rc1

On Tue, May 07, 2019 at 01:33:06PM -0700, Linus Torvalds wrote:
> On Tue, May 7, 2019 at 10:59 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > All of these have been in linux-next for a while with no reported
> > issues, other than an odd gcc warning for one of the new drivers that
> > should be fixed up soon.
> 
> Ok, that's truly a funky warning.
> 
> But since I don't deal well with warnings, particularly during the
> merge window, I just fixed it up in the merge.
> 
> The fix is to simply not have a bitfield base type of "unsigned char",
> and have it cross a char boundary. Instead the base type should just
> be "unsigned int".

Ah, that's how to resolve that, thanks, it wasn't obvious at all from
the odd gcc warning.

> Of course, I couldn't test my change, but it shuts the compiler up,
> and it very much looks like the right thing.

The driver author can test it out, given that it needs loads of work
anyway, whatever you did to it is fine :)

thanks,

greg k-h