linux-kernel - Re: [PATCH v7 11/13] ARM: dts: exynos: add syscon to clock compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPf3tZGp-UQagGKNs0xFBGz2NwBdA2R=Y25C5jTK_ZcMXg@mail.gmail.com>
Date:   Wed, 8 May 2019 12:17:02 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lukasz Luba <l.luba@...tner.samsung.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, kgene@...nel.org,
        Chanwoo Choi <cw00.choi@...sung.com>,
        kyungmin.park@...sung.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        s.nawrocki@...sung.com, myungjoo.ham@...sung.com,
        keescook@...omium.org, tony@...mide.com, jroedel@...e.de,
        treding@...dia.com, digetx@...il.com, willy.mh.wolff.ml@...il.com
Subject: Re: [PATCH v7 11/13] ARM: dts: exynos: add syscon to clock compatible

On Wed, 8 May 2019 at 11:50, Lukasz Luba <l.luba@...tner.samsung.com> wrote:
>
>
> On 5/8/19 9:22 AM, Krzysztof Kozlowski wrote:
> > On Mon, 6 May 2019 at 17:12, Lukasz Luba <l.luba@...tner.samsung.com> wrote:
> >>
> >> In order get the clock by phandle and use it with regmap it needs to be
> >> compatible with syscon. The DMC driver uses two registers from clock
> >> register set and needs the regmap of them.
> >>
> >> Signed-off-by: Lukasz Luba <l.luba@...tner.samsung.com>
> >> ---
> >>   arch/arm/boot/dts/exynos5800.dtsi | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
> >> index 57d3b31..0a2b328 100644
> >> --- a/arch/arm/boot/dts/exynos5800.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5800.dtsi
> >> @@ -17,7 +17,7 @@
> >>   };
> >>
> >>   &clock {
> >> -       compatible = "samsung,exynos5800-clock";
> >> +       compatible = "samsung,exynos5800-clock", "syscon";
> >
> > What about Exynos5420 DTSI?
> OK, I will also add it to 5420 dtsi.
> --------------------------8<------------------------------------------
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index aaff158..d9203f0 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -173,7 +173,7 @@
>                  };
>
>                  clock: clock-controller@...10000 {
> -                       compatible = "samsung,exynos5420-clock";
> +                       compatible = "samsung,exynos5420-clock", "syscon";
>                          reg = <0x10010000 0x30000>;
>                          #clock-cells = <1>;
>                  };
> diff --git a/arch/arm/boot/dts/exynos5800.dtsi
> b/arch/arm/boot/dts/exynos5800.dtsi
> index 57d3b31..0a2b328 100644
> --- a/arch/arm/boot/dts/exynos5800.dtsi
> +++ b/arch/arm/boot/dts/exynos5800.dtsi
> @@ -17,7 +17,7 @@
>   };
>
>   &clock {
> -       compatible = "samsung,exynos5800-clock";
> +       compatible = "samsung,exynos5800-clock", "syscon";
>   };
> ----------------------------->8-----------------------------------
>
> Can I add your ack after that?

No need for ack. The DTS have to go through arm-soc so I will pick it
up when dependencies get in and bindings are accepted (acked or
applied). We have now merge window so I guess this will go to v5.4-rc1
at earliest.

If you want to speed up things in future, be sure that dependencies
(headers) are applied as early as possible.

Best regards,
Krzysztof