[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <74d20a42-b6cf-48d3-7777-a44e500b0eed@roeck-us.net>
Date: Tue, 7 May 2019 18:47:43 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Angus Ainslie (Purism)" <angus@...ea.ca>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] usb: typec: tcpci: read the VBUS_VOLTAGE register
On 5/7/19 5:40 PM, Angus Ainslie (Purism) wrote:
> I don't have a setup that I can test this code right now.
>
> I did test the tcpci_get_vbus_voltage and on my setup it is always 0.
>
Odd. PTN5110 is supposed to support it, though the datasheet is a bit vague about it.
It may be disabled. Did you check the status of POWER_CONTROL.VBUS_VOLTAGEMonitor ?
> I don't currently have setup that I can adjust the vbus voltage to
> trigger the fault.
>
> Angus Ainslie (Purism) (1):
> usb: typec: tcpci: add functions to read the VBUS voltage
>
> drivers/usb/typec/tcpm/tcpci.c | 35 ++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
In general, an introductory patch is only useful if there is more than one patch.
Thanks,
Guenter
Powered by blists - more mailing lists