linux-kernel - Re: [PATCH] net: hns3: remove redundant assignment of l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4627235-16a8-60be-4e7b-0a7e36df55c9@huawei.com>
Date:   Wed, 8 May 2019 20:13:17 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S . Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: hns3: remove redundant assignment of l2_hdr to
 itself

On 2019/5/8 18:51, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer l2_hdr is being assigned to itself, this is redundant
> and can be removed.
> 
> Addresses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 18711e0f9bdf..196a3d780dcf 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -810,7 +810,7 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto,
>  			   u8 il4_proto, u32 *type_cs_vlan_tso,
>  			   u32 *ol_type_vlan_len_msec)
>  {
> -	unsigned char *l2_hdr = l2_hdr = skb->data;
> +	unsigned char *l2_hdr = skb->data;

Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>

Thanks.

>  	u32 l4_proto = ol4_proto;
>  	union l4_hdr_info l4;
>  	union l3_hdr_info l3;
>