linux-kernel - Re: [PATCH] fs: make all new mount api fds cloexec by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4158.1557324343@warthog.procyon.org.uk>
Date:   Wed, 08 May 2019 15:05:43 +0100
From:   David Howells <dhowells@...hat.com>
To:     Christian Brauner <christian@...uner.io>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: make all new mount api fds cloexec by default

Christian Brauner <christian@...uner.io> wrote:

> -	fd = get_unused_fd_flags(flags & O_CLOEXEC);
> +	fd = get_unused_fd_flags(flags | O_CLOEXEC);

That'll break if there are any flags other than O_CLOEXEC.

> -	ret = get_unused_fd_flags((flags & FSMOUNT_CLOEXEC) ? O_CLOEXEC : 0);
> +	ret = get_unused_fd_flags(flags | O_CLOEXEC);

That'll break because flags is not compatible with what get_unused_fd_flags()
is expecting.

David