linux-kernel - Re: [PATCH 02/25] tracing: Improve "if" macro code generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509150644.13d4a046@gandalf.local.home>
Date:   Thu, 9 May 2019 15:06:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        David Laight <David.Laight@...lab.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "hpa@...or.com" <hpa@...or.com>,
        "julien.thierry@....com" <julien.thierry@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "luto@...capital.net" <luto@...capital.net>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "james.morse@....com" <james.morse@....com>,
        "valentin.schneider@....com" <valentin.schneider@....com>,
        "brgerst@...il.com" <brgerst@...il.com>,
        "luto@...nel.org" <luto@...nel.org>, "bp@...en8.de" <bp@...en8.de>,
        "dvlasenk@...hat.com" <dvlasenk@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dvyukov@...gle.com" <dvyukov@...gle.com>
Subject: Re: [PATCH 02/25] tracing: Improve "if" macro code generation

On Thu, 9 May 2019 13:45:31 -0500
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> Actually, my original fix already went in:
> 
>   37686b1353cf ("tracing: Improve "if" macro code generation")
> 
> But it introduced a regression:
> 
>   https://lkml.kernel.org/r/201905040509.iqQ2CrOU%lkp@intel.com
> 
> which Linus' patch fixes for some reason.

Hmm, I'm still working on my pull request for the merge window, and if
this already went in, I could just add this, and let it conflict. I'm
sure Linus will have no problems in fixing up the conflicts.

I should change the subject, as it is the same ;-) Perhaps to:

 tracing: Clean up "if" macro

But it would be good to find out why this fixes the issue you see.
Perhaps its because we remove the internal if statement?

-- Steve