linux-kernel - Re: [PATCH 3/3] hwrng: add mt67xx-rng driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509052649.xfkgb3qd7rhcgktj@gondor.apana.org.au>
Date:   Thu, 9 May 2019 13:26:49 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Neal Liu <neal.liu@...iatek.com>
Cc:     Stephan Mueller <smueller@...onox.de>, mpm@...enic.com,
        robh+dt@...nel.org, mark.rutland@....com, matthias.bgg@...il.com,
        wsd_upstream@...iatek.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, Crystal.Guo@...iatek.com
Subject: Re: [PATCH 3/3] hwrng: add mt67xx-rng driver

On Wed, May 08, 2019 at 06:35:37PM +0800, Neal Liu wrote:
> Hi Stephan,
> 	We think the cast is fine, and it cannot guarantee the buf is
> word-align.
> 	I reference multiple rng driver's implementation and found it's common
> usage for this. So it might be general usage for community. Is there any
> suggestion that is more appropriate?

If you don't know whether it's unaligned or not then you should
do an unaligned operation.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt