linux-kernel - Re: [PATCH v2 1/3] x86/tsc: use CPUID.0x16 to calculate missing crystal frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509090718.GA11209@gmail.com>
Date:   Thu, 9 May 2019 11:07:18 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Daniel Drake <drake@...lessm.com>, mingo@...hat.com, bp@...en8.de,
        hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org,
        len.brown@...el.com, rafael.j.wysocki@...el.com,
        linux@...lessm.com, peterz@...radead.org
Subject: Re: [PATCH v2 1/3] x86/tsc: use CPUID.0x16 to calculate missing
 crystal frequency


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Thu, 9 May 2019, Daniel Drake wrote:
> 
> > native_calibrate_tsc() had a data mapping Intel CPU families
> > and crystal clock speed, but hardcoded tables are not ideal, and this
> > approach was already problematic at least in the Skylake X case, as
> > seen in commit b51120309348 ("x86/tsc: Fix erroneous TSC rate on Skylake
> > Xeon").
> 
> ...
> 
> For the whole pile:
> 
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

Thanks - applied it to tip:x86/apic, will push it out after a bit of 
testing.

Thanks,

	Ingo