linux-kernel - Re: [PATCH net V3 1/2] tuntap: fix dividing by zero in ebpf queue selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a244711-657c-88f9-6463-c503d178dd02@gmail.com>
Date:   Thu, 9 May 2019 04:35:38 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     yuehaibing@...wei.com, xiyou.wangcong@...il.com,
        weiyongjun1@...wei.com, eric.dumazet@...il.com
Subject: Re: [PATCH net V3 1/2] tuntap: fix dividing by zero in ebpf queue
 selection



On 5/8/19 11:20 PM, Jason Wang wrote:
> We need check if tun->numqueues is zero (e.g for the persist device)
> before trying to use it for modular arithmetic.
> 
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Fixes: 96f84061620c6("tun: add eBPF based queue selection method")
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.