linux-kernel - Re: [PATCH] sync_file: Return reasonable timestamp when merging signaled fences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 May 2019 12:46:05 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Michael Yang <michael.yang@...tec.com>, sumit.semwal@...aro.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        gustavo@...ovan.org, linux-media@...r.kernel.org,
        linaro-mm-sig@...ts.linaro.org, michael.yang@...tec.com,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH] sync_file: Return reasonable timestamp when merging signaled
 fences

Quoting Michael Yang (2019-05-09 05:34:11)
> If all the sync points were signaled in both fences a and b,
> there was only one sync point in merged fence which is a_fence[0].
> The Fence structure in android framework might be confused about
> timestamp if there were any sync points which were signaled after
> a_fence[0]. It might be more reasonable to use timestamp of last signaled
> sync point to represent the merged fence.
> The issue can be found from EGL extension ANDROID_get_frame_timestamps.
> Sometimes the return value of EGL_READS_DONE_TIME_ANDROID is head of
> the return value of EGL_RENDERING_COMPLETE_TIME_ANDROID.
> That means display/composition had been completed before rendering
> was completed that is incorrect.
> 
> Some discussion can be found at:
> https://android-review.googlesource.com/c/kernel/common/+/907009
> 
> Signed-off-by: Michael Yang <michael.yang@...tec.com>
> ---
> Hi,
> I didn't get response since I previously sent this a month ago.
> Could someone have a chance to look at it please?
> Thanks.
>  drivers/dma-buf/sync_file.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
> index 4f6305c..d46bfe1 100644
> --- a/drivers/dma-buf/sync_file.c
> +++ b/drivers/dma-buf/sync_file.c
> @@ -274,8 +274,29 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a,
>         for (; i_b < b_num_fences; i_b++)
>                 add_fence(fences, &i, b_fences[i_b]);
>  
> -       if (i == 0)
> -               fences[i++] = dma_fence_get(a_fences[0]);
> +       /* If all the sync pts were signaled, then adding the sync_pt who
> +        * was the last signaled to the fence.
> +        */
> +       if (i == 0) {
> +               struct dma_fence *last_signaled_sync_pt = a_fences[0];
> +               int iter;
> +
> +               for (iter = 1; iter < a_num_fences; iter++) {

If there is more than one fence, sync_file->fence is a fence_array and
its timestamp is what you want. If there is one fence, sync_file->fence
is a pointer to that fence, and naturally has the right timestamp.

In short, this should be handled by dma_fence_array_create() when given
a complete set of signaled fences, it too should inherit the signaled
status with the timestamp being taken from the last fence. It should
also be careful to inherit the error status.
-Chris