linux-kernel - Re: [PATCH v7 1/1] usb: xhci: Add Clear_TT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 May 2019 14:25:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jim Lin <jilin@...dia.com>
Cc:     mathias.nyman@...el.com, stern@...land.harvard.edu,
        kai.heng.feng@...onical.com, drinkcat@...omium.org,
        keescook@...omium.org, nsaenzjulienne@...e.de, jflat@...omium.org,
        malat@...ian.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/1] usb: xhci: Add Clear_TT_Buffer

On Thu, May 09, 2019 at 08:03:15PM +0800, Jim Lin wrote:
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -625,6 +625,7 @@ struct usb3_lpm_parameters {
>   *		parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns)
>   *
>   *	Will be used as wValue for SetIsochDelay requests.
> + * @devaddr: address on a USB bus, assigned by controller like XHCI
>   *
>   * Notes:
>   * Usbcore drivers should not set usbdev->state directly.  Instead use
> @@ -709,6 +710,7 @@ struct usb_device {
>  	unsigned lpm_disable_count;
>  
>  	u16 hub_delay;
> +	int devaddr;

Shouldn't this be u32?