linux-kernel - Re: [PATCH v7 6/6] perf-probe: Add user memory access attribute support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190509234143.d2f6cc6979daba4252ba410f@kernel.org>
Date:   Thu, 9 May 2019 23:41:43 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Changbin Du <changbin.du@...il.com>,
        Jann Horn <jannh@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...nel.org>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Nadav Amit <namit@...are.com>,
        Joel Fernandes <joel@...lfernandes.org>, yhs@...com
Subject: Re: [PATCH v7 6/6] perf-probe: Add user memory access attribute
 support

On Thu, 9 May 2019 11:17:35 +0200
Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > --- a/tools/perf/util/probe-event.h
> > +++ b/tools/perf/util/probe-event.h
> > @@ -37,6 +37,7 @@ struct probe_trace_point {
> >  struct probe_trace_arg_ref {
> >  	struct probe_trace_arg_ref	*next;	/* Next reference */
> >  	long				offset;	/* Offset value */
> > +	bool				user;	/* User-memory access */
> >  };
> >  
> >  /* kprobe-tracer and uprobe-tracer tracing argument */
> > @@ -82,6 +83,7 @@ struct perf_probe_arg {
> >  	char				*var;	/* Variable name */
> >  	char				*type;	/* Type name */
> >  	struct perf_probe_arg_field	*field;	/* Structure fields */
> > +	bool				user;	/* User-memory */
> 
> Why did the 'access' qualifier get dropped from the second comment?

Ah, it's my typo.

> Also, please name it and related parameters and local variables 
> 'user_access' - in that case no comments are needed and it's all super 
> clear. Only 'user' is ambiguous really.

Yes, that's a good idea! OK. I'll change it.

Thank you!

> 
> Thanks,
> 
> 	ngo


-- 
Masami Hiramatsu <mhiramat@...nel.org>