linux-kernel - Re: [PATCH] net: aquantia: fix undefined devm_hwmon_device_register_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190509.095015.756311298864539257.davem@davemloft.net>
Date:   Thu, 09 May 2019 09:50:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wangkefeng.wang@...wei.com
Cc:     yana.esina@...antia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, hulkci@...wei.com
Subject: Re: [PATCH] net: aquantia: fix undefined
 devm_hwmon_device_register_with_info reference

From: Kefeng Wang <wangkefeng.wang@...wei.com>
Date: Thu, 9 May 2019 23:32:35 +0800

> drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.o: In function `aq_drvinfo_init':
> aq_drvinfo.c:(.text+0xe8): undefined reference to `devm_hwmon_device_register_with_info'
> 
> Fix it by using #if IS_REACHABLE(CONFIG_HWMON).
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Applied.

It's a shame there isn't a dummy inline of this helper defined when HWMON is unset.