linux-kernel - RE: PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB324703AD3D285BA287A389FD91330@VI1PR04MB3247.eurprd04.prod.outlook.com>
Date:   Thu, 9 May 2019 02:28:25 +0000
From:   Qiang Zhao <qiang.zhao@....com>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Leo Li <leoyang.li@....com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Scott Wood <oss@...error.net>,
        Christophe Leroy <christophe.leroy@....fr>,
        Mark Rutland <mark.rutland@....com>,
        Rasmus Villemoes <Rasmus.Villemoes@...vas.se>
Subject: RE: PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier

On 2019/5/1 17:29, Rasmus Villemoes <rasmus.villemoes@...vas.dk> wrote:
> -----Original Message-----
> From: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> Sent: 2019年5月1日 17:29
> To: devicetree@...r.kernel.org; Qiang Zhao <qiang.zhao@....com>; Leo Li
> <leoyang.li@....com>
> Cc: linuxppc-dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; Rob Herring <robh+dt@...nel.org>; Scott Wood
> <oss@...error.net>; Christophe Leroy <christophe.leroy@....fr>; Mark
> Rutland <mark.rutland@....com>; Rasmus Villemoes
> <Rasmus.Villemoes@...vas.se>
> Subject: [PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier
> 
> The local variable snum_init has no reason to have static storage duration.
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@....fr>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>

Reviewed-by: Qiang Zhao <qiang.zhao@....com>

> ---
>  drivers/soc/fsl/qe/qe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> 612d9c551be5..855373deb746 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -306,7 +306,7 @@ static void qe_snums_init(void)
>                 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
>                 0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
>         };
> -       static const u8 *snum_init;
> +       const u8 *snum_init;
> 
>         qe_num_of_snum = qe_get_num_of_snums();
> 
> --
> 2.20.1


Best Regards
Qiang Zhao