linux-kernel - Re: [PATCH 02/10] PCI/PME: Replace dev_printk(KERN_DEBUG) with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve9-659N5N=f7pPb-9amvbGbi+zWxL9p-BnYocvXJPwZg@mail.gmail.com>
Date:   Thu, 9 May 2019 20:35:00 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Frederick Lawler <fred@...dlawl.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Keith Busch <keith.busch@...el.com>,
        Dongdong Liu <liudongdong3@...wei.com>,
        Sven Van Asbroeck <thesven73@...il.com>,
        linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 02/10] PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info()

On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more
> consistent with other logging.
>
> These could be converted to dev_dbg(), but that depends on
> CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to
> *always* be in the dmesg log.
>
> Also, use dev_fmt() to add the service name.  Example output change:
>
>   - pcieport 0000:80:10.0: Signaling PME with IRQ ...
>   + pcieport 0000:80:10.0: PME: Signaling with IRQ ...

> +               pci_info(port, "interrupt generated for non-existent device %02x:%02x.%d\n",

Can we be slightly more consistent here, i.e. start from Capital letter?

> +                        busnr, PCI_SLOT(devfn), PCI_FUNC(devfn));

> +               pci_info(port, "Spurious native interrupt!\n");

> +       pci_info(port, "Signaling with IRQ %d\n", srv->irq);

-- 
With Best Regards,
Andy Shevchenko