linux-kernel - RE: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 May 2019 05:28:18 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Yue Haibing <yuehaibing@...wei.com>,
        "QLogic-Storage-Upstream@...ium.com" 
        <QLogic-Storage-Upstream@...ium.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH -next] scsi: qedi: remove set but not used variables
 'cdev' and 'udev'


> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org <linux-scsi-
> owner@...r.kernel.org> On Behalf Of Yue Haibing
> Sent: Wednesday, April 24, 2019 1:33 PM
> To: QLogic-Storage-Upstream@...ium.com; jejb@...ux.ibm.com;
> martin.petersen@...cle.com
> Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; YueHaibing
> <yuehaibing@...wei.com>
> Subject: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev'
> and 'udev'
> 
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
> drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not
> used [-Wunused-but-set-variable]
> drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not
> used [-Wunused-but-set-variable]
> 
> They are never used since introduction.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/scsi/qedi/qedi_iscsi.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
> index e4391ee..688a6d8 100644
> --- a/drivers/scsi/qedi/qedi_iscsi.c
> +++ b/drivers/scsi/qedi/qedi_iscsi.c
> @@ -809,8 +809,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
>  	struct qedi_endpoint *qedi_ep;
>  	struct sockaddr_in *addr;
>  	struct sockaddr_in6 *addr6;
> -	struct qed_dev *cdev  =  NULL;
> -	struct qedi_uio_dev *udev = NULL;
>  	struct iscsi_path path_req;
>  	u32 msg_type = ISCSI_KEVENT_IF_DOWN;
>  	u32 iscsi_cid = QEDI_CID_RESERVED;
> @@ -830,8 +828,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
>  	}
> 
>  	qedi = iscsi_host_priv(shost);
> -	cdev = qedi->cdev;
> -	udev = qedi->udev;
> 
>  	if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) ||
>  	    test_bit(QEDI_IN_RECOVERY, &qedi->flags)) {
> --
> 2.7.4
> 

Thanks,

Acked-by: Manish Rangankar <mrangankar@...vell.com>