linux-kernel - Re: [PATCH 2/2] kconfig: do not write .config if the content is the same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARuDrYEgR8_U=mK2E22bc4JL_b4_5=wvJMc0siZio8S+A@mail.gmail.com>
Date:   Fri, 10 May 2019 16:14:09 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] kconfig: do not write .config if the content is the same

On Fri, May 10, 2019 at 3:21 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, May 10, 2019 at 03:12:05PM +0900, Masahiro Yamada wrote:
> > Kconfig updates the .config when it exits even if its content is
> > exactly the same as before. Since its timestamp becomes newer than
> > that of other build artifacts, additional processing is invoked,
> > which is annoying.
> >
> > - syncconfig is invoked to update include/config/auto.conf, etc.
> >
> > - kernel/config.o is recompiled if CONFIG_IKCONFIG is enabled,
> >   then vmlinux is relinked as well.
> >
> > If the .config is not changed at all, we do not have to even
> > touch it. Just bail out showing "No change to .config".
> >
> >   $ make allmodconfig
> >   scripts/kconfig/conf  --allmodconfig Kconfig
> >   #
> >   # configuration written to .config
> >   #
> >   $ make allmodconfig
> >   scripts/kconfig/conf  --allmodconfig Kconfig
> >   #
> >   # No change to .config
> >   #
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org> ?

OK.

For reviewers who do not know the context,
please see this comment from Linus:

https://lkml.org/lkml/2019/5/9/983



-- 
Best Regards
Masahiro Yamada