linux-kernel - Re: [PATCH V2] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 May 2019 21:50:43 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <rdunlap@...radead.org>
CC:     <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>
Subject: Re: [PATCH V2] ASoC: SOF: Fix build error with
 CONFIG_SND_SOC_SOF_NOCODEC=m

On 2019/5/10 21:36, Pierre-Louis Bossart wrote:
> On 5/10/19 8:29 AM, YueHaibing wrote:
>> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
>>
>> sound/soc/sof/core.o: In function `snd_sof_device_probe':
>> core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup'
>>
>> Change IS_ENABLED to IS_REACHABLE to fix this.
> 
> this just hides the issue instead of fixing it.
> please send the config+sha1 so that we can check.

Sure,  config sha1 5fdc79b550c1d850eee604aa58bad4d6da9223f0

> 
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Suggested-by: Takashi Iwai <tiwai@...e.de>
>> Fixes: c16211d6226d ("ASoC: SOF: Add Sound Open Firmware driver core")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>> V2: use IS_REACHABLE
>> ---
>>   sound/soc/sof/core.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c
>> index 32105e0..38e22f4 100644
>> --- a/sound/soc/sof/core.c
>> +++ b/sound/soc/sof/core.c
>> @@ -259,7 +259,7 @@ int snd_sof_create_page_table(struct snd_sof_dev *sdev,
>>   static int sof_machine_check(struct snd_sof_dev *sdev)
>>   {
>>       struct snd_sof_pdata *plat_data = sdev->pdata;
>> -#if IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)
>> +#if IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC)
>>       struct snd_soc_acpi_mach *machine;
>>       int ret;
>>   #endif
>> @@ -267,7 +267,7 @@ static int sof_machine_check(struct snd_sof_dev *sdev)
>>       if (plat_data->machine)
>>           return 0;
>>   -#if !IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)
>> +#if !IS_REACHABLE(CONFIG_SND_SOC_SOF_NOCODEC)
>>       dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n");
>>       return -ENODEV;
>>   #else
>>
> 
> 
> .
> 

View attachment "config" of type "text/plain" (167773 bytes)