linux-kernel - Re: [PATCH v1] mtd: rawnand: Add Macronix NAND read retry support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190510161805.202e6aea@xps13>
Date:   Fri, 10 May 2019 16:18:05 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     Mason Yang <masonccyang@...c.com.tw>, bbrezillon@...nel.org,
        marek.vasut@...il.com, linux-kernel@...r.kernel.org,
        richard@....at, dwmw2@...radead.org, computersforpeace@...il.com,
        linux-mtd@...ts.infradead.org, juliensu@...c.com.tw
Subject: Re: [PATCH v1] mtd: rawnand: Add Macronix NAND read retry support

Hello,

Thomas Petazzoni <thomas.petazzoni@...tlin.com> wrote on Fri, 10 May
2019 15:37:04 +0200:

> Hello,
> 
> Some purely cosmetic suggestions below.
> 
> On Fri, 10 May 2019 15:41:02 +0800
> Mason Yang <masonccyang@...c.com.tw> wrote:
> 
> > +	if (ret)
> > +		pr_err("set feature failed to read retry moded:%d\n", mode);    
> 
> I don't know what is the policy in the MTD/NAND subsystem, but
> shouldn't you be using dev_err() instead of pr_err() here to have a
> nice prefix for the message ?
> 
> 		dev_err(&nand_to_mtd(chip)->dev, "set feature ..", mode);

Actually, no, manufacturer initializations happens in
nand_scan_tail() which runs before mtd_device_register(). At this
point, mtd->dev is not yet populated so dev_err() cannot be used. You
should keep a pr_err().


Thanks,
Miquèl