linux-kernel - Re: [PATCH] power: supply: ucs1002: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190510162239.qbnmtw7fxszwbwiw@earth.universe>
Date:   Fri, 10 May 2019 18:22:39 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     YueHaibing <yuehaibing@...wei.com>, andrew.smirnov@...il.com,
        enric.balletbo@...labora.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] power: supply: ucs1002: Fix build error without
 CONFIG_REGULATOR

Hi,

On Fri, May 10, 2019 at 06:05:06AM -0700, Guenter Roeck wrote:
> On 5/10/19 12:18 AM, YueHaibing wrote:
> > Fix gcc build error while CONFIG_REGULATOR is not set
> > 
> > drivers/power/supply/ucs1002_power.o: In function `ucs1002_probe':
> > drivers/power/supply/ucs1002_power.c:593: undefined reference to `devm_regulator_register'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3b8): undefined reference to `regulator_enable_regmap'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3c0): undefined reference to `regulator_disable_regmap'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3c8): undefined reference to `regulator_is_enabled_regmap'
> > 
> > Add Kconfig dependency to CONFIG_REGULATOR.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Fixes: 9a2688e42638 ("power: supply: Add driver for Microchip UCS1002")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)