linux-kernel - Re: [PATCH 1/2] iio: dac: ds4422/ds4424 drop of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 May 2019 12:20:06 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Ruslan Babayev <ruslan@...ayev.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        xe-linux-external@...co.com, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check

On Sun,  5 May 2019 12:24:36 -0700
Ruslan Babayev <ruslan@...ayev.com> wrote:

> The driver doesn't actually rely on any DT properties. Removing this
> check makes it usable on ACPI based platforms.
> 
> Signed-off-by: Ruslan Babayev <ruslan@...ayev.com>
> Cc: xe-linux-external@...co.com
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ds4424.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 883a47562055..2b3ba1a66fe8 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -236,12 +236,6 @@ static int ds4424_probe(struct i2c_client *client,
>  	indio_dev->dev.of_node = client->dev.of_node;
>  	indio_dev->dev.parent = &client->dev;
>  
> -	if (!client->dev.of_node) {
> -		dev_err(&client->dev,
> -				"Not found DT.\n");
> -		return -ENODEV;
> -	}
> -
>  	data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
>  	if (IS_ERR(data->vcc_reg)) {
>  		dev_err(&client->dev,