linux-kernel - Re: [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190511124905.11d24e5b@archlinux>
Date:   Sat, 11 May 2019 12:49:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Ruslan Babayev <ruslan@...ayev.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        xe-linux-external@...co.com, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

On Sun,  5 May 2019 12:24:37 -0700
Ruslan Babayev <ruslan@...ayev.com> wrote:

> The ds4424_get_value function takes channel number as it's 3rd
> argument and translates it internally into I2C address using
> DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
> already translated I2C address as its last argument.
> 
> Signed-off-by: Ruslan Babayev <ruslan@...ayev.com>
> Cc: xe-linux-external@...co.com
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ds4424.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 2b3ba1a66fe8..ae9be792693b 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
>  {
>  	int ret, val;
>  
> -	ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
> +	ret = ds4424_get_value(indio_dev, &val, 0);
>  	if (ret < 0)
>  		dev_err(&indio_dev->dev,
>  				"%s failed. ret: %d\n", __func__, ret);