linux-kernel - Re: [PATCH v2] jbd2: fix potential double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190511013701.GD2534@mit.edu>
Date:   Fri, 10 May 2019 21:37:01 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Chengguang Xu <cgxu519@...il.com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] jbd2: fix potential double free

On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote:
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 37e16d969925..0f1ac43d0560 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2299,7 +2299,7 @@ static void jbd2_journal_destroy_slabs(void)
>  	}
>  }
>  
> -static int jbd2_journal_create_slab(size_t size)
> +static int __init jbd2_journal_create_slab(size_t size)
>  {
>  	static DEFINE_MUTEX(jbd2_slab_create_mutex);
>  	int i = order_base_2(size) - 10;

I had to remove this hunk.  It's incorrect, since jbd2_journal_load
calls this function when mounting file systems.  So it can't be marked
__init.

						- Ted