linux-kernel - Re: [PATCH] irqchip: ingenic: Drop dependency on MACH_INGENIC, use COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1557600189.1898.0@crapouillou.net>
Date:   Sat, 11 May 2019 20:43:09 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     od@...c.me, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: ingenic: Drop dependency on MACH_INGENIC, use
 COMPILE_TEST

My bad, I'm stupid. I tested CONFIG_COMPILE_TEST on MIPS...

The driver does depend on arch-specific includes so COMPILE_TEST
cannot be used; I'll send a V2.

-Paul


Le sam. 11 mai 2019 à 19:09, Paul Cercueil <paul@...pouillou.net> a 
écrit :
> Depending on MACH_INGENIC prevent us from creating a generic kernel 
> that
> works on more than one MIPS board. Instead, we just depend on MIPS 
> being
> set.
> 
> On other architectures, this driver can still be built, thanks to
> COMPILE_TEST. This is used by automated tools to find bugs, for
> instance.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/irqchip/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 5438abb1baba..864dc38782e8 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -286,9 +286,9 @@ config MIPS_GIC
>  	select MIPS_CM
> 
>  config INGENIC_IRQ
> -	bool
> -	depends on MACH_INGENIC
> -	default y
> +	bool "Ingenic JZ47xx IRQ controller driver"
> +	depends on MIPS || COMPILE_TEST
> +	default MACH_INGENIC
> 
>  config RENESAS_H8300H_INTC
>          bool
> --
> 2.21.0.593.g511ec345e18
>