linux-kernel - Re: [PATCH] selftests: fix bpf build/test workflow regression when KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190511043729.3o4enh35lrmne3kd@ast-mbp>
Date:   Fri, 10 May 2019 21:37:31 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     shuah@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        torvalds@...ux-foundation.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] selftests: fix bpf build/test workflow regression when
 KBUILD_OUTPUT is set

On Fri, May 10, 2019 at 08:52:49PM -0600, Shuah Khan wrote:
> commit 8ce72dc32578 ("selftests: fix headers_install circular dependency")
> broke bpf build/test workflow. When KBUILD_OUTPUT is set, bpf objects end
> up in KBUILD_OUTPUT build directory instead of in ../selftests/bpf.
> 
> The following bpf workflow breaks when it can't find the test_verifier:
> 
> cd tools/testing/selftests/bpf; make; ./test_verifier;
> 
> Fix it to set OUTPUT only when it is undefined in lib.mk. It didn't need
> to be set in the first place.
> 
> Fixes: commit 8ce72dc32578 ("selftests: fix headers_install circular dependency")
> 
> Reported-by: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

'git am' couldn't apply this patch because "sha1 information is lacking",
but the patch itself looks good.
Acked-by: Alexei Starovoitov <ast@...nel.org>
Thanks for the quick fix.