linux-kernel - Re: [PATCH] spi: TI power management: add missing of table registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 May 2019 10:28:21 +0200
From:   Daniel G <dagmcr@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     open list <linux-kernel@...r.kernel.org>,
        Javier Martinez Canillas <javier@...hile0.org>
Subject: Re: [PATCH] spi: TI power management: add missing of table registration

On Wed, May 8, 2019 at 12:27 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> The subject line is not correct.  This is an MFD driver.
>
> When submitting you should follow the convention for the subsystem you
> are patching against.  The following command is helpful:
>
>   `git log --oneline -- <SUBSYSTEM>`
>
> I will fix it for you this time (and for the other patch I see).
>
Sorry for that and thanks for rewriting the subject.

> On Mon, 22 Apr 2019, Daniel Gomez wrote:
>
> > MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> > OF mathing mechanism and register it.
> >
> > Before this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          spi:tps65912
> >
> > After this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          of:N*T*Cti,tps65912C*
> > alias:          of:N*T*Cti,tps65912
> > alias:          spi:tps65912
> >
> > Reported-by: Javier Martinez Canillas <javier@...hile0.org>
> > Signed-off-by: Daniel Gomez <dagmcr@...il.com>
> > ---
> >  drivers/mfd/tps65912-spi.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied, thanks.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog