linux-kernel - Re: [PATCH] nvme/pci: Use host managed power state for suspend

Open Source and information security mailing list archives

Message-ID: <SN6PR04MB45276B524D255F667A6BE29E860E0@SN6PR04MB4527.namprd04.prod.outlook.com>
Date:   Sun, 12 May 2019 15:20:59 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Minwoo Im <minwoo.im.dev@...il.com>
CC:     Sagi Grimberg <sagi@...mberg.me>,
        Mario Limonciello <Mario.Limonciello@...l.com>,
        linux-pm <linux-pm@...r.kernel.org>,
        Rafael Wysocki <rafael@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        Keith Busch <keith.busch@...el.com>,
        Kai Heng Feng <kai.heng.feng@...onical.com>,
        "hange-folder>?" <toggle-mailboxes@...wooim-desktop>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend

Disregard my comment.

On 5/12/19 7:31 AM, Minwoo Im wrote:
>>> +	union nvme_result res;
>>> +	int ret;
>>> +
>>> +	if (!result)
>>> +		return -EINVAL;
>>> +
>>> +	memset(&c, 0, sizeof(c));
>>> +	c.features.opcode = nvme_admin_get_features;
>>> +	c.features.fid = cpu_to_le32(NVME_FEAT_POWER_MGMT);
>>> +
>>> +	ret = __nvme_submit_sync_cmd(ctrl->admin_q, &c, &res,
>>> +			NULL, 0, 0, NVME_QID_ANY, 0, 0, false);
>>> +	if (ret >= 0)
>>> +		*result = le32_to_cpu(res.u32);
>> May be add a check for result here in above if before deref pointer :-
>> 	if (ret >= 0 && result)
>>
> 'result' already has been checked in a few lines above.
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives