[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190512075417.GG21483@sirena.org.uk>
Date: Sun, 12 May 2019 16:54:17 +0900
From: Mark Brown <broonie@...nel.org>
To: Viorel Suman <viorel.suman@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
"S.j. Wang" <shengjiu.wang@....com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Daniel Baluta <daniel.baluta@....com>,
Colin Ian King <colin.king@...onical.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>,
Viorel Suman <viorel.suman@...il.com>
Subject: Re: [PATCH 1/2] ASoC: ak4458: rstn_control - return a non-zero on
error only
On Thu, May 09, 2019 at 01:30:36PM +0000, Viorel Suman wrote:
> - return ret;
> + /* Return a negative error code only. */
> + return (ret < 0 ? ret : 0);
Please write normal conditional statements to help people who have to
read the code.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists