linux-kernel - Re: [PATCH V1] elan_i2c: Increment wakeup count if wake source.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRQ_J6QWxtWpoRQnNWKcJpXox6xVDZWcWYOXkBhPSn99Rw@mail.gmail.com>
Date:   Mon, 13 May 2019 16:29:23 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Ravi Chandra Sadineni <ravisadineni@...omium.org>
Cc:     廖崇榮 <kt.liao@....com.tw>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Abhishek Bhardwaj <abhishekbh@...gle.com>,
        Todd Broch <tbroch@...gle.com>,
        lkml <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH V1] elan_i2c: Increment wakeup count if wake source.

Hi Ravi,

On Mon, May 13, 2019 at 3:06 PM Ravi Chandra Sadineni
<ravisadineni@...omium.org> wrote:
>
> Notify the PM core that this dev is the wake source. This helps
> userspace daemon tracking the wake source to identify the origin of the
> wake.

I wonder if we could do that form the i2c core instead of individual drivers?

>
> Signed-off-by: Ravi Chandra Sadineni <ravisadineni@...omium.org>
> ---
>  drivers/input/mouse/elan_i2c_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index f9525d6f0bfe..2c0561e20b7f 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -981,6 +981,8 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
>         if (error)
>                 goto out;
>
> +       pm_wakeup_event(dev, 0);
> +
>         switch (report[ETP_REPORT_ID_OFFSET]) {
>         case ETP_REPORT_ID:
>                 elan_report_absolute(data, report);
> --
> 2.20.1
>

Thanks.

-- 
Dmitry